Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(next-core): adjust og alias #57431

Merged
merged 1 commit into from
Oct 25, 2023
Merged

fix(next-core): adjust og alias #57431

merged 1 commit into from
Oct 25, 2023

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Oct 25, 2023 •
edited by padmaia
Loading

What?

minor adjustment to the alias to reflect latest changes:

next.js/packages/next/src/server/web/spec-extension/image-response.ts

Line 3 in 9c87ea5

'ImageResponse moved from "next/server" to "next/og" since Next.js 14, please import from "next/og" instead'

Closes WEB-1861

@kwonoj kwonoj requested review from timneutkens, ijjk, shuding, huozhi and a team as code owners October 25, 2023 17:08
@ijjk ijjk added Turbopack Related to Turbopack with Next.js. created-by: Turbopack team PRs by the Turbopack team. type: next labels Oct 25, 2023
@ijjk
Copy link
Member

ijjk commented Oct 25, 2023

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js og-import-alias Change
buildDuration 10.2s 10.2s N/A
buildDurationCached 6s 6s N/A
nodeModulesSize 175 MB 175 MB ✓
nextStartRea..uration (ms) 396ms 395ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js og-import-alias Change
199-HASH.js gzip 32.3 kB 32.4 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB N/A
99.HASH.js gzip 182 B 182 B ✓
framework-HASH.js gzip 45.5 kB 45.5 kB ✓
main-app-HASH.js gzip 254 B 251 B N/A
main-HASH.js gzip 35.3 kB 35.4 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 45.7 kB 45.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js og-import-alias Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js og-import-alias Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB ✓
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 369 B 369 B ✓
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 316 B 318 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 319 B 319 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.99 kB 3.99 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js og-import-alias Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js og-import-alias Change
index.html gzip 528 B 530 B N/A
link.html gzip 542 B 543 B N/A
withRouter.html gzip 524 B 524 B ✓
Overall change 524 B 524 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js og-import-alias Change
edge-ssr.js gzip 96 kB 96 kB N/A
page.js gzip 139 kB 140 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js og-import-alias Change
middleware-b..fest.js gzip 624 B 626 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 25.8 kB 25.8 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB ✓
Overall change 1.92 kB 1.92 kB ✓
Commit: d2c21bf

@ijjk
Copy link
Member

ijjk commented Oct 25, 2023 •
edited
Loading

Tests Passed

@kodiakhq kodiakhq bot merged commit 945edac into canary Oct 25, 2023
54 of 59 checks passed
@kodiakhq kodiakhq bot deleted the og-import-alias branch October 25, 2023 17:31
@kwonoj kwonoj mentioned this pull request Oct 25, 2023
Merged
@github-actions github-actions bot added the locked label Nov 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sokra sokra sokra approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the Turbopack team. locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kwonoj @ijjk @sokra